Skip to content

setup-kubectl-and-helm - #5

Merged
alexlanz merged 2 commits into
mainfrom
setup-kubectl-and-helm
May 18, 2025
Merged

setup-kubectl-and-helm#5
alexlanz merged 2 commits into
mainfrom
setup-kubectl-and-helm

Conversation

@alexlanz

@alexlanz alexlanz commented May 15, 2025

Copy link
Copy Markdown
Member

No description provided.

@alexlanz
alexlanz requested a review from stplasim May 15, 2025 20:43
Comment thread setup-kubectl-and-helm/action.yml Outdated
kubectl-version:
description: 'kubectl version'
required: false
default: 'latest'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use the latest versions of Kubectl and Helm. It's very non-deterministic. It would be better to just make it required and force the CI to pin it. The versions of Kubectl and Helm should also be aligned with the cluster version to some extent.
https://helm.sh/docs/topics/version_skew/

@alexlanz
alexlanz requested a review from stplasim May 16, 2025 11:31
@ThoSap

ThoSap commented May 16, 2025

Copy link
Copy Markdown
Member

I'm sorry for chiming in on this PR without a review you requested.
I just saw this PR as I checked the possibly needed roles for the Rancher CI tokens (searched the helm-spring-deployment repo).

Using kubectl v1.33.1 even if we are on Kubernetes v1.32.2 currently is absolutely fine here 👍🏼
https://kubernetes.io/releases/version-skew-policy/#kubectl

@alexlanz
alexlanz merged commit abff7c3 into main May 18, 2025
@alexlanz
alexlanz deleted the setup-kubectl-and-helm branch May 18, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants